Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1409143011: Revert of Initialize maths result array in JS. (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
Reviewers:
Igor Sheludko, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Initialize maths result array in JS. (patchset #1 id:1 of https://codereview.chromium.org/1421703004/ ) Reason for revert: Failed on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/5020 Original issue's description: > Initialize maths result array in JS. > > R=ishell@chromium.org > > Committed: https://crrev.com/aa26f5d4a11a1e5655d425ff40ced79c8ecdd55f > Cr-Commit-Position: refs/heads/master@{#31722} TBR=ishell@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7d7292a692b0c404a03c69743f4622623c4c654f Cr-Commit-Position: refs/heads/master@{#31723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M src/bootstrapper.cc View 4 chunks +24 lines, -0 lines 0 comments Download
M src/js/prologue.js View 4 chunks +6 lines, -4 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of Initialize maths result array in JS.
5 years, 1 month ago (2015-11-02 23:33:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409143011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409143011/1
5 years, 1 month ago (2015-11-02 23:33:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 23:33:52 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 23:34:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d7292a692b0c404a03c69743f4622623c4c654f
Cr-Commit-Position: refs/heads/master@{#31723}

Powered by Google App Engine
This is Rietveld 408576698