fixes #24713, remove old generic substitution code in _getTypeOfProperty

fixes #24713, remove old generic substitution code in _getTypeOfProperty

it looks like some old code was hanging around that tried to substitute generic type parameters by name. This is unnecessary because we already have a substituted type at this point, and the type variable we were substituting had no relationship at all with the parameter. After removing the code, all tests seem to be passing.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/396ed51cf04cfdfd3f33e6803a32e6a9cbfeefcf

[Jennifer Messerly, 2015-10-24 00:26:16]

Description was changed from

==========
fixes #24713, remove old generic substitution code in _getTypeOfProperty

it looks like some old code was hanging around that tried to substitute generic
type parameters by name. This is unncessary because we already have a
substituted type at this point.
==========

to

==========
fixes #24713, remove old generic substitution code in _getTypeOfProperty

it looks like some old code was hanging around that tried to substitute generic
type parameters by name. This is unnecessary because we already have a
substituted type at this point, and the type variable we were substituting had
no relationship at all with the parameter. After removing the code, all tests
seem to be passing.
==========

[Jennifer Messerly, 2015-10-24 00:26:16]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com

[Jennifer Messerly, 2015-10-24 00:28:54]

https://codereview.chromium.org/1409143009/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1409143009/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1638:
PropertyAccessorElement accessor, DartType context) {
oops, just noticed: I should really remove the "context" here too, as it's
unused now.

[Jennifer Messerly, 2015-10-24 00:32:36]

PTAL. Ready now :)

[Brian Wilkerson, 2015-10-24 00:39:01]

LGTM. Thanks!

[Jennifer Messerly, 2015-10-24 19:48:57]

Committed patchset #2 (id:20001) manually as
396ed51cf04cfdfd3f33e6803a32e6a9cbfeefcf (presubmit successful).