Revert of QUIC - Disable QUIC when there is bad packet loss rate (50% of the

Revert of QUIC - Disable QUIC when there is bad packet loss rate (50% of the (patchset #2 id:40001 of https://codereview.chromium.org/1326763007/ )

Reason for revert:
BUG=546089
We want to run bad packet loss as an experiment because on youtube, it had a negative impact.

Original issue's description:
> QUIC - Disable QUIC when there is bad packet loss rate (50% of the
> packets are lost) for 4 consecutive crypto handshakes.
> 
> For a session, during crypto handshake if there is a bad packet loss
> rate, then we mark that QUIC is recently broken for that host/port.
> 
> We disable QUIC and close that connections if 4 consecutive handshakes
> have bad packet loss rate. QUIC was disabled for 0.002% of the time.
> 
> We have been running the above experiment in M45 (in Canary, Dev and
> Beta). In M45 Beta, Net.HttpJob.TotalTimeNotCached.Quic's mean is
> faster by 4.4% (for data aggreagted for 28 days) when this experiment
> was enabled.
> 
> R=rch@chromium.org
> 
> Committed: https://crrev.com/147024676acbf52d08179457d2909314cf423a5c
> Cr-Commit-Position: refs/heads/master@{#347871}

TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

[ramant (doing other things), 2015-10-21 18:17:19]

Created Revert of QUIC - Disable QUIC when there is bad packet loss rate (50% of
the

[ramant (doing other things), 2015-10-21 18:17:38]

Description was changed from

==========
Revert of QUIC - Disable QUIC when there is bad packet loss rate (50% of the
(patchset #2 id:40001 of https://codereview.chromium.org/1326763007/ )

Reason for revert:
BUG=546089

We want to run bad packet loss as an experiment because on youtube, it had a
negative impact.

Original issue's description:
> QUIC - Disable QUIC when there is bad packet loss rate (50% of the
> packets are lost) for 4 consecutive crypto handshakes.
> 
> For a session, during crypto handshake if there is a bad packet loss
> rate, then we mark that QUIC is recently broken for that host/port.
> 
> We disable QUIC and close that connections if 4 consecutive handshakes
> have bad packet loss rate. QUIC was disabled for 0.002% of the time.
> 
> We have been running the above experiment in M45 (in Canary, Dev and
> Beta). In M45 Beta, Net.HttpJob.TotalTimeNotCached.Quic's mean is
> faster by 4.4% (for data aggreagted for 28 days) when this experiment
> was enabled.
> 
> R=rch@chromium.org
> 
> Committed: https://crrev.com/147024676acbf52d08179457d2909314cf423a5c
> Cr-Commit-Position: refs/heads/master@{#347871}

TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of QUIC - Disable QUIC when there is bad packet loss rate (50% of the
(patchset #2 id:40001 of https://codereview.chromium.org/1326763007/ )

Reason for revert:
BUG=546089

We want to run bad packet loss as an experiment because on youtube, it had a
negative impact.

Original issue's description:
> QUIC - Disable QUIC when there is bad packet loss rate (50% of the
> packets are lost) for 4 consecutive crypto handshakes.
> 
> For a session, during crypto handshake if there is a bad packet loss
> rate, then we mark that QUIC is recently broken for that host/port.
> 
> We disable QUIC and close that connections if 4 consecutive handshakes
> have bad packet loss rate. QUIC was disabled for 0.002% of the time.
> 
> We have been running the above experiment in M45 (in Canary, Dev and
> Beta). In M45 Beta, Net.HttpJob.TotalTimeNotCached.Quic's mean is
> faster by 4.4% (for data aggreagted for 28 days) when this experiment
> was enabled.
> 
> R=rch@chromium.org
> 
> Committed: https://crrev.com/147024676acbf52d08179457d2909314cf423a5c
> Cr-Commit-Position: refs/heads/master@{#347871}

TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2015-10-21 18:17:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409143007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409143007/1

[commit-bot: I haz the power, 2015-10-21 18:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 18:19:40]

Failed to apply patch for chrome/browser/io_thread_unittest.cc:
While running git apply --index -3 -p1;
  error: patch failed: chrome/browser/io_thread_unittest.cc:170
  Falling back to three-way merge...
  Applied patch to 'chrome/browser/io_thread_unittest.cc' with conflicts.
  U chrome/browser/io_thread_unittest.cc

Patch:       chrome/browser/io_thread_unittest.cc
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc
b/chrome/browser/io_thread_unittest.cc
index
2d6a6c607fbe08a9ef70ffbe845c512a097b75bc..2633f43bbff2306aaa3c0b736b3035668f460e7f
100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -170,8 +170,8 @@
   EXPECT_FALSE(params.quic_disable_disk_cache);
   EXPECT_FALSE(params.quic_prefer_aes);
   EXPECT_FALSE(params.use_alternative_services);
-  EXPECT_EQ(4, params.quic_max_number_of_lossy_connections);
-  EXPECT_EQ(0.5f, params.quic_packet_loss_threshold);
+  EXPECT_EQ(0, params.quic_max_number_of_lossy_connections);
+  EXPECT_EQ(1.0f, params.quic_packet_loss_threshold);
   EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
 }
 
@@ -384,11 +384,11 @@
 
 TEST_F(IOThreadTest, QuicPacketLossThresholdFieldTrialParams) {
   field_trial_group_ = "Enabled";
-  field_trial_params_["packet_loss_threshold"] = "0.6";
-  ConfigureQuicGlobals();
-  net::HttpNetworkSession::Params params;
-  InitializeNetworkSessionParams(&params);
-  EXPECT_EQ(0.6f, params.quic_packet_loss_threshold);
+  field_trial_params_["packet_loss_threshold"] = "0.5";
+  ConfigureQuicGlobals();
+  net::HttpNetworkSession::Params params;
+  InitializeNetworkSessionParams(&params);
+  EXPECT_EQ(0.5f, params.quic_packet_loss_threshold);
 }
 
 TEST_F(IOThreadTest, QuicReceiveBufferSize) {

[commit-bot: I haz the power, 2015-10-21 18:21:26]

The CQ bit was unchecked by commit-bot@chromium.org