Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.cc

Issue 1409143004: Only allow action buttons in persistent notifications per spec update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sw-not-props
Patch Set: Address review nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/layout_test/layout_test_notification_manager.cc
diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.cc b/content/shell/browser/layout_test/layout_test_notification_manager.cc
index 3a0433b380db744a5acc548df565a4bda247303f..82cc07df3232a4b5e2a970097cee7f626ae50777 100644
--- a/content/shell/browser/layout_test/layout_test_notification_manager.cc
+++ b/content/shell/browser/layout_test/layout_test_notification_manager.cc
@@ -113,7 +113,8 @@ void LayoutTestNotificationManager::SimulateClick(const std::string& title,
// First check for page-notifications with the given title.
const auto& page_iterator = page_notifications_.find(title);
if (page_iterator != page_notifications_.end()) {
- // TODO(johnme): Pass action_index once it's supported.
+ DCHECK_EQ(action_index, -1) << "Action buttons are only supported for "
+ "persistent notifications";
page_iterator->second->NotificationClick();
return;
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698