Only allow action buttons in persistent notifications per spec update

content/shell/browser/layout_test/layout_test_notification_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/layout_test/layout_test_notification_manager.h"
 
 #include "base/guid.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/desktop_notification_delegate.h"
@@ skipping 95 matching lines @@
   return false;
 }
 
 void LayoutTestNotificationManager::SimulateClick(const std::string& title,
                                                   int action_index) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   // First check for page-notifications with the given title.
   const auto& page_iterator = page_notifications_.find(title);
   if (page_iterator != page_notifications_.end()) {
-    // TODO(johnme): Pass action_index once it's supported.
+    DCHECK_EQ(action_index, -1) << "Action buttons are only supported for "

[Peter Beverloo, 2015/10/21 17:02:52]

Can we have a constant please? That also removes the need to have the comment.

[johnme, 2015/10/21 18:11:31]

I'll add the constant in a follow-up patch to avoid ballooning this one (I'll
still need the comment though, to explain why the DCHECK is there).

+                                   "persistent notifications";
     page_iterator->second->NotificationClick();
     return;
   }
 
   // Then check for persistent notifications with the given title.
   const auto& persistent_iterator = persistent_notifications_.find(title);
   if (persistent_iterator == persistent_notifications_.end())
     return;
 
   const PersistentNotification& notification = persistent_iterator->second;
@@ skipping 68 matching lines @@
 LayoutTestNotificationManager::CheckPermission(const GURL& origin) {
   return ToWebNotificationPermission(LayoutTestContentBrowserClient::Get()
       ->GetLayoutTestBrowserContext()
       ->GetLayoutTestPermissionManager()
       ->GetPermissionStatus(PermissionType::NOTIFICATIONS,
                             origin,
                             origin));
 }
 
 }  // namespace content