Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: components/dom_distiller/core/page_features_unittest.cc

Issue 1409133007: Add a new set of page features for distillability testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webkit
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/page_features_unittest.cc
diff --git a/components/dom_distiller/core/page_features_unittest.cc b/components/dom_distiller/core/page_features_unittest.cc
index 8e259e4382bb39a998cfe82e692d03233792c1c6..d2ebd8f525277ec92f5be7c6d797e28af6692e11 100644
--- a/components/dom_distiller/core/page_features_unittest.cc
+++ b/components/dom_distiller/core/page_features_unittest.cc
@@ -13,6 +13,8 @@
#include "base/memory/scoped_ptr.h"
#include "base/path_service.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/platform/WebDistillability.h"
+#include "url/gurl.h"
namespace dom_distiller {
@@ -95,4 +97,70 @@ TEST(DomDistillerPageFeaturesTest, TestCalculateDerivedFeatures) {
}
}
}
+
+TEST(DomDistillerPageFeaturesTest, TestPath) {
+ blink::WebDistillabilityFeatures f = blink::WebDistillabilityFeatures();
+
+ GURL url("http://example.com/search/view/index/the-title-of-archive.php");
+
+ std::vector<double> derived(CalculateDerivedFeatures(f, url));
+ EXPECT_EQ(0, lround(derived[1]));
+ EXPECT_EQ(1, lround(derived[2]));
+ EXPECT_EQ(1, lround(derived[3]));
+ EXPECT_EQ(1, lround(derived[4]));
+ EXPECT_EQ(1, lround(derived[5]));
+ EXPECT_EQ(0, lround(derived[6]));
+ EXPECT_EQ(0, lround(derived[7]));
+ EXPECT_EQ(1, lround(derived[8]));
+ EXPECT_EQ(43, lround(derived[9]));
+ EXPECT_EQ(0, lround(derived[10]));
+ EXPECT_EQ(4, lround(derived[11]));
+ EXPECT_EQ(4, lround(derived[12]));
+ EXPECT_EQ(0, lround(derived[13]));
+ EXPECT_EQ(24, lround(derived[14]));
+}
+
+TEST(DomDistillerPageFeaturesTest, TestPath2) {
+ blink::WebDistillabilityFeatures f = blink::WebDistillabilityFeatures();
+
+ GURL url("http://example.com/phpbb/forum123/456.asp");
+
+ std::vector<double> derived(CalculateDerivedFeatures(f, url));
+ EXPECT_EQ(1, lround(derived[1]));
+ EXPECT_EQ(0, lround(derived[2]));
+ EXPECT_EQ(0, lround(derived[3]));
+ EXPECT_EQ(0, lround(derived[4]));
+ EXPECT_EQ(0, lround(derived[5]));
+ EXPECT_EQ(1, lround(derived[6]));
+ EXPECT_EQ(1, lround(derived[7]));
+ EXPECT_EQ(0, lround(derived[8]));
+ EXPECT_EQ(23, lround(derived[9]));
+ EXPECT_EQ(0, lround(derived[10]));
+ EXPECT_EQ(3, lround(derived[11]));
+ EXPECT_EQ(1, lround(derived[12]));
+ EXPECT_EQ(2, lround(derived[13]));
+ EXPECT_EQ(7, lround(derived[14]));
+}
+
+TEST(DomDistillerPageFeaturesTest, TestPath3) {
+ blink::WebDistillabilityFeatures f = blink::WebDistillabilityFeatures();
+
+ GURL url("https://example.com/");
+
+ std::vector<double> derived(CalculateDerivedFeatures(f, url));
+ EXPECT_EQ(0, lround(derived[1]));
+ EXPECT_EQ(0, lround(derived[2]));
+ EXPECT_EQ(0, lround(derived[3]));
+ EXPECT_EQ(0, lround(derived[4]));
+ EXPECT_EQ(0, lround(derived[5]));
+ EXPECT_EQ(0, lround(derived[6]));
+ EXPECT_EQ(0, lround(derived[7]));
+ EXPECT_EQ(0, lround(derived[8]));
+ EXPECT_EQ(1, lround(derived[9]));
+ EXPECT_EQ(1, lround(derived[10]));
+ EXPECT_EQ(0, lround(derived[11]));
+ EXPECT_EQ(0, lround(derived[12]));
+ EXPECT_EQ(0, lround(derived[13]));
+ EXPECT_EQ(0, lround(derived[14]));
+}
}
« components/dom_distiller/DEPS ('K') | « components/dom_distiller/core/page_features.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698