Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 140913011: Trim FontSelector interface a bit. (Closed)

Created:
6 years, 11 months ago by dglazkov
Modified:
6 years, 11 months ago
Reviewers:
Kunihiko Sakamoto, eae
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Stephen Chennney, aandrey+blink_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Trim FontSelector interface a bit. A two-parter: 1) Split off FontCacheClient interface and make FontCache forget about FontSelector altogether. 2) De-interface font invalidation callback registration/unregisration, since they are only used in Source/core. This costs us a couple of static_casts, but overall, it still looks cleaner. R=ksakamoto@chromium.org,eae BUG=315783 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165351

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -58 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/css/CSSFontSelectorClient.h View 1 chunk +11 lines, -7 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 6 chunks +7 lines, -7 lines 1 comment Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/FontCache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
A + Source/platform/fonts/FontCacheClient.h View 1 chunk +11 lines, -6 lines 0 comments Download
M Source/platform/fonts/FontSelector.h View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dglazkov
6 years, 11 months ago (2014-01-17 22:27:35 UTC) #1
eae
LGTM https://codereview.chromium.org/140913011/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/140913011/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode181 Source/core/html/canvas/CanvasRenderingContext2D.cpp:181: static_cast<CSSFontSelector*>(m_font.fontSelector())->registerForInvalidationCallbacks(this); I'm not thrilled about all these casts, ...
6 years, 11 months ago (2014-01-17 23:13:26 UTC) #2
dglazkov
On 2014/01/17 23:13:26, eae wrote: > LGTM > > https://codereview.chromium.org/140913011/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp > File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): > ...
6 years, 11 months ago (2014-01-17 23:15:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/140913011/1
6 years, 11 months ago (2014-01-17 23:16:07 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-18 00:46:11 UTC) #5
Message was sent while issue was closed.
Change committed as 165351

Powered by Google App Engine
This is Rietveld 408576698