[Android WebView] Reflect system font scale in WebView text rendering.

[Android WebView] Reflect system font scale in WebView text rendering.

We should take into account the font scale factor the user has chosen
when drawing text in the WebView.

(Also fixes presubmit warnings in AwSettings.java)

BUG=335343
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245582

[johnme, 2014-01-16 23:35:15]

lgtm

[benm (inactive), 2014-01-17 02:17:00]

ptal Mikhail.

[mnaganov (inactive), 2014-01-17 09:20:46]

LGTM, thanks!

Are we planning also to handle the system setting change while the application
is running?

[boliu, 2014-01-17 16:46:28]

I'm gonna cq this for you so I can get past presubmit for
https://codereview.chromium.org/140753006/ afterwards :)

[commit-bot: I haz the power, 2014-01-17 16:46:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/140913003/50001

[benm (inactive), 2014-01-17 18:28:09]

On 2014/01/17 09:20:46, Mikhail Naganov (Cr) wrote:
> LGTM, thanks!
> 
> Are we planning also to handle the system setting change while the application
> is running?

The font scale change is considered a Configuration change on Android, which by
default will restart activities; thus they will notice the new value when the
WebView gets recreated. In testing, I noticed that this is the case for Dolphin.

If an app elects to handle the configuration change themselves (e.g. BBC News),
then the app won't pick up the new setting until it is manually restarted. This
is a kind of sucky experience, but I'm not sure that there's anything we can do
at the View level to fix this (the callback for Configuration changes occurs on
the Activity). The other option would be to add an API to set the font scale
factor which an app handling Configuration changes itself could invoke, but that
will require an Android API bump, and to be honest I'm not entirely convinced
it's worth another knob to twiddle on WebSettings.

[commit-bot: I haz the power, 2014-01-17 19:26:24]

Change committed as 245582

[mnaganov (inactive), 2014-01-20 09:40:33]

On 2014/01/17 18:28:09, benm wrote:
> On 2014/01/17 09:20:46, Mikhail Naganov (Cr) wrote:
> > LGTM, thanks!
> > 
> > Are we planning also to handle the system setting change while the
application
> > is running?
> 
> The font scale change is considered a Configuration change on Android, which
by
> default will restart activities; thus they will notice the new value when the
> WebView gets recreated. In testing, I noticed that this is the case for
Dolphin.
> 
> If an app elects to handle the configuration change themselves (e.g. BBC
News),
> then the app won't pick up the new setting until it is manually restarted.
This
> is a kind of sucky experience, but I'm not sure that there's anything we can
do
> at the View level to fix this (the callback for Configuration changes occurs
on
> the Activity). The other option would be to add an API to set the font scale
> factor which an app handling Configuration changes itself could invoke, but
that
> will require an Android API bump, and to be honest I'm not entirely convinced
> it's worth another knob to twiddle on WebSettings.

I agree, no need for that. Thanks for the explanation!