Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140913002: Remove deferred repaint code from FrameView (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, adamk, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, abarth-chromium, eseidel, jamesr, Ian Vollick, dsinclair
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove deferred repaint code from FrameView This code depends on the REPAINT_THROTTLING define which is disabled. The repaint throttling makes the FrameView code more complex than it needs to be. Removing it simplifies the code quite a bit. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165589

Patch Set 1 #

Patch Set 2 : Remove more dead code #

Patch Set 3 : Remove more dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -161 lines) Patch
M Source/core/frame/FrameView.h View 1 4 chunks +0 lines, -14 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 7 chunks +0 lines, -137 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 4 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Inactive
6 years, 11 months ago (2014-01-16 16:18:36 UTC) #1
eseidel
6 years, 11 months ago (2014-01-16 16:28:47 UTC) #2
esprehn
lgtm
6 years, 11 months ago (2014-01-22 01:12:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/140913002/80001
6 years, 11 months ago (2014-01-22 01:12:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18488
6 years, 11 months ago (2014-01-22 05:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/140913002/80001
6 years, 11 months ago (2014-01-22 14:02:08 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8626
6 years, 11 months ago (2014-01-22 17:28:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/140913002/80001
6 years, 11 months ago (2014-01-22 17:44:59 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8701
6 years, 11 months ago (2014-01-22 21:28:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/140913002/80001
6 years, 11 months ago (2014-01-22 21:42:33 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 01:50:08 UTC) #11
Message was sent while issue was closed. 
Change committed as 165589

Powered by Google App Engine
This is Rietveld 408576698