Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1409123010: Extract glyph find and position code. (Closed)

Created:
5 years, 1 month ago by herb_g
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@extract-glyph-position-code
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Extract glyph find and position code in preparation to use it in XPS and GPU code. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e5911c9c5b859d60208f4b9ac4bf2a638f4bc35f

Patch Set 1 #

Patch Set 2 : cleaned up #

Total comments: 2

Patch Set 3 : fix bad param formatting #

Patch Set 4 : remove constexpr #

Patch Set 5 : undef the constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -488 lines) Patch
M gyp/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkDraw.cpp View 1 2 3 chunks +6 lines, -488 lines 0 comments Download
A src/core/SkFindAndPlaceGlyph.h View 1 2 3 4 1 chunk +523 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
herb_g
5 years, 1 month ago (2015-11-09 19:52:48 UTC) #3
mtklein
lgtm https://codereview.chromium.org/1409123010/diff/20001/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/1409123010/diff/20001/src/core/SkDraw.cpp#newcode1778 src/core/SkDraw.cpp:1778: scalarsPerPosition, funky indent on these args (and below)?
5 years, 1 month ago (2015-11-09 19:58:15 UTC) #4
herb_g
https://codereview.chromium.org/1409123010/diff/20001/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/1409123010/diff/20001/src/core/SkDraw.cpp#newcode1778 src/core/SkDraw.cpp:1778: scalarsPerPosition, On 2015/11/09 19:58:15, mtklein wrote: > funky indent ...
5 years, 1 month ago (2015-11-09 20:04:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409123010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409123010/40001
5 years, 1 month ago (2015-11-09 20:04:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4183)
5 years, 1 month ago (2015-11-09 20:06:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409123010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409123010/60001
5 years, 1 month ago (2015-11-09 20:29:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409123010/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409123010/80001
5 years, 1 month ago (2015-11-09 21:03:47 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 21:15:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e5911c9c5b859d60208f4b9ac4bf2a638f4bc35f

Powered by Google App Engine
This is Rietveld 408576698