Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1409123007: Move public SDK test targets to //mojo/BUILD.gn (from //mojo/edk/test/BUILD.gn). (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move public SDK test targets to //mojo/BUILD.gn (from //mojo/edk/test/BUILD.gn). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/71ad8e77f1db714e1a1c5f80ac7848ad450ab2f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -77 lines) Patch
M mojo/BUILD.gn View 3 chunks +77 lines, -1 line 0 comments Download
M mojo/edk/test/BUILD.gn View 2 chunks +0 lines, -76 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 1 month ago (2015-10-27 22:35:45 UTC) #1
jamesr
lgtm
5 years, 1 month ago (2015-10-27 22:39:36 UTC) #2
viettrungluu
5 years, 1 month ago (2015-10-27 22:40:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71ad8e77f1db714e1a1c5f80ac7848ad450ab2f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698