Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1409123005: Add methods for telling V8 how much memory audio/video is using. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/demuxer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 8fff086bd972c94c7323801d4d8ddfd2e128ed7a..b76010225dd1f1bd774ae5be52aea8d5d91c03f7 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2142,6 +2142,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
audio_renderer_sink, media_log, render_thread->GetMediaThreadTaskRunner(),
render_thread->GetWorkerTaskRunner(),
render_thread->compositor_task_runner(), context_3d_cb,
+ base::Bind(&v8::Isolate::AdjustAmountOfExternalAllocatedMemory,
+ base::Unretained(blink::mainThreadIsolate())),
jochen (gone - plz use gerrit) 2015/10/28 14:41:26 btw, it's important that you invoke this callback
haraken 2015/10/28 14:45:36 mainThreadIsolate() has ASSERT(isMainThread()). O
DaleCurtis 2015/10/28 17:56:01 Yup, main thread callbacks only. WMPI includes a D
GetMediaPermission(), initial_cdm);
// TODO(xhwang, watk): Find a better way to specify these ifdef conditions.
« no previous file with comments | « no previous file | media/base/demuxer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698