content/renderer/render_frame_impl.cc - Issue 1409123005: Add methods for telling V8 how much memory audio/video is using.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1409123005: Add methods for telling V8 how much memory audio/video is using. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Add unittests. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 8fff086bd972c94c7323801d4d8ddfd2e128ed7a..b76010225dd1f1bd774ae5be52aea8d5d91c03f7 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -2142,6 +2142,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(

audio_renderer_sink, media_log, render_thread->GetMediaThreadTaskRunner(),

render_thread->GetWorkerTaskRunner(),

render_thread->compositor_task_runner(), context_3d_cb,

+ base::Bind(&v8::Isolate::AdjustAmountOfExternalAllocatedMemory,

+ base::Unretained(blink::mainThreadIsolate())),

GetMediaPermission(), initial_cdm);

// TODO(xhwang, watk): Find a better way to specify these ifdef conditions.

« no previous file with comments | « no previous file | media/base/demuxer.h » ('j') | media/base/pipeline.cc » ('J')