media/base/pipeline_status.h - Issue 1409123005: Add methods for telling V8 how much memory audio/video is using.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/pipeline_status.h

Issue 1409123005: Add methods for telling V8 how much memory audio/video is using. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mock filter. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/pipeline_status.h

diff --git a/media/base/pipeline_status.h b/media/base/pipeline_status.h

index daec9237988e7c809b3e3d572e529c4f09100c60..e179a05aa178d9eda0dbb180866d1cb3546485d0 100644

--- a/media/base/pipeline_status.h

+++ b/media/base/pipeline_status.h

@@ -44,13 +44,16 @@ struct PipelineStatistics {

: audio_bytes_decoded(0),

video_bytes_decoded(0),

video_frames_decoded(0),

- video_frames_dropped(0) {

- }

+ video_frames_dropped(0),

+ audio_memory_usage(-1),

+ video_memory_usage(-1) {}

uint32 audio_bytes_decoded; // Should be uint64?

uint32 video_bytes_decoded; // Should be uint64?

uint32 video_frames_decoded;

uint32 video_frames_dropped;

+ int64_t audio_memory_usage;

+ int64_t video_memory_usage;

xhwang 2015/10/25 17:01:56 nit: how about using the c++11 Non-Static Class Me

DaleCurtis 2015/10/27 23:14:20 Done.

};

// Used for updating pipeline statistics.

« media/base/pipeline.cc ('K') | « media/base/pipeline.cc ('k') | media/blink/buffered_data_source.h » ('j') | media/blink/webmediaplayer_impl.cc » ('J')