Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: media/base/pipeline_status.h

Issue 1409123005: Add methods for telling V8 how much memory audio/video is using. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix html viewer. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline.cc ('k') | media/blink/buffered_data_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_status.h
diff --git a/media/base/pipeline_status.h b/media/base/pipeline_status.h
index daec9237988e7c809b3e3d572e529c4f09100c60..b59219ca98606d14179cbd8a8f5cde1542afb3e4 100644
--- a/media/base/pipeline_status.h
+++ b/media/base/pipeline_status.h
@@ -38,22 +38,17 @@ enum PipelineStatus {
typedef base::Callback<void(PipelineStatus)> PipelineStatusCB;
-// TODO(scherkus): this should be moved alongside host interface definitions.
struct PipelineStatistics {
- PipelineStatistics()
- : audio_bytes_decoded(0),
- video_bytes_decoded(0),
- video_frames_decoded(0),
- video_frames_dropped(0) {
- }
-
- uint32 audio_bytes_decoded; // Should be uint64?
- uint32 video_bytes_decoded; // Should be uint64?
- uint32 video_frames_decoded;
- uint32 video_frames_dropped;
+ uint64_t audio_bytes_decoded = 0; // Should be uint64?
+ uint32 video_bytes_decoded = 0; // Should be uint64?
+ uint32 video_frames_decoded = 0;
+ uint32 video_frames_dropped = 0;
+ int64_t audio_memory_usage = 0;
+ int64_t video_memory_usage = 0;
};
-// Used for updating pipeline statistics.
+// Used for updating pipeline statistics; the passed value should be a delta
+// of all attributes since the last update.
typedef base::Callback<void(const PipelineStatistics&)> StatisticsCB;
} // namespace media
« no previous file with comments | « media/base/pipeline.cc ('k') | media/blink/buffered_data_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698