Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: media/base/pipeline_status.h

Issue 1409123005: Add methods for telling V8 how much memory audio/video is using. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Add unittests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_PIPELINE_STATUS_H_ 5 #ifndef MEDIA_BASE_PIPELINE_STATUS_H_
6 #define MEDIA_BASE_PIPELINE_STATUS_H_ 6 #define MEDIA_BASE_PIPELINE_STATUS_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 9
10 #include <string> 10 #include <string>
(...skipping 20 matching lines...) Expand all
31 DEMUXER_ERROR_COULD_NOT_PARSE = 13, 31 DEMUXER_ERROR_COULD_NOT_PARSE = 13,
32 DEMUXER_ERROR_NO_SUPPORTED_STREAMS = 14, 32 DEMUXER_ERROR_NO_SUPPORTED_STREAMS = 14,
33 // Decoder related errors. 33 // Decoder related errors.
34 DECODER_ERROR_NOT_SUPPORTED = 15, 34 DECODER_ERROR_NOT_SUPPORTED = 15,
35 // Must be equal to the largest value ever logged. 35 // Must be equal to the largest value ever logged.
36 PIPELINE_STATUS_MAX = DECODER_ERROR_NOT_SUPPORTED, 36 PIPELINE_STATUS_MAX = DECODER_ERROR_NOT_SUPPORTED,
37 }; 37 };
38 38
39 typedef base::Callback<void(PipelineStatus)> PipelineStatusCB; 39 typedef base::Callback<void(PipelineStatus)> PipelineStatusCB;
40 40
41 // TODO(scherkus): this should be moved alongside host interface definitions. 41 // TODO(scherkus): this should be moved alongside host interface definitions.
xhwang 2015/10/27 23:32:40 nit: Is this still accurate?
DaleCurtis 2015/10/28 01:08:28 Done.
42 struct PipelineStatistics { 42 struct PipelineStatistics {
43 PipelineStatistics() 43 uint32 audio_bytes_decoded = 0; // Should be uint64?
44 : audio_bytes_decoded(0), 44 uint32 video_bytes_decoded = 0; // Should be uint64?
45 video_bytes_decoded(0), 45 uint32 video_frames_decoded = 0;
46 video_frames_decoded(0), 46 uint32 video_frames_dropped = 0;
47 video_frames_dropped(0) { 47 int64_t audio_memory_usage = 0;
48 } 48 int64_t video_memory_usage = 0;
49
50 uint32 audio_bytes_decoded; // Should be uint64?
51 uint32 video_bytes_decoded; // Should be uint64?
52 uint32 video_frames_decoded;
53 uint32 video_frames_dropped;
54 }; 49 };
55 50
56 // Used for updating pipeline statistics. 51 // Used for updating pipeline statistics.
57 typedef base::Callback<void(const PipelineStatistics&)> StatisticsCB; 52 typedef base::Callback<void(const PipelineStatistics&)> StatisticsCB;
58 53
59 } // namespace media 54 } // namespace media
60 55
61 #endif // MEDIA_BASE_PIPELINE_STATUS_H_ 56 #endif // MEDIA_BASE_PIPELINE_STATUS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698