Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: src/lookup.h

Issue 1409123003: [runtime] Avoid @@isConcatSpreadable lookup for fast path Array.prototype.concat (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: merging with master Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate-inl.h ('k') | src/lookup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 4cd4ece75d68a3af1823f4101476cc3ead66395d..13286deea3977cfcf10cc90df0b1c11e374e0161 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -263,9 +263,10 @@ class LookupIterator final BASE_EMBEDDED {
Handle<Object> GetDataValue() const;
void WriteDataValue(Handle<Object> value);
inline void UpdateProtector() {
- if (FLAG_harmony_species && !IsElement() &&
- (*name_ == heap()->constructor_string() ||
- *name_ == heap()->species_symbol())) {
+ if (IsElement()) return;
+ if (*name_ == heap()->is_concat_spreadable_symbol() ||
+ (FLAG_harmony_species && (*name_ == heap()->constructor_string() ||
+ *name_ == heap()->species_symbol()))) {
InternalUpdateProtector();
}
}
@@ -353,8 +354,6 @@ class LookupIterator final BASE_EMBEDDED {
State NotFound(JSReceiver* const holder) const;
- bool HolderIsInContextIndex(uint32_t index) const;
-
// If configuration_ becomes mutable, update
// HolderIsReceiverOrHiddenPrototype.
const Configuration configuration_;
« no previous file with comments | « src/isolate-inl.h ('k') | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698