src/elements.h - Issue 1409123003: [runtime] Avoid @@isConcatSpreadable lookup for fast path Array.prototype.concat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.h

Issue 1409123003: [runtime] Avoid @@isConcatSpreadable lookup for fast path Array.prototype.concat (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: merging with master Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/elements.h

diff --git a/src/elements.h b/src/elements.h

index d6716fcba4da69b3a74ec25ffcaca201123ca9d9..9f70f2a0c753864e72ddb5f84754304a42ddfa8a 100644

--- a/src/elements.h

+++ b/src/elements.h

@@ -128,7 +128,7 @@ class ElementsAccessor {

uint32_t new_capacity) = 0;

static Handle<JSArray> Concat(Isolate* isolate, Arguments* args,

- uint32_t concat_size);

+ uint32_t concat_size, uint32_t result_length);

virtual uint32_t Push(Handle<JSArray> receiver, Arguments* args,

uint32_t push_size) = 0;

« no previous file with comments | « src/deoptimizer.cc ('k') | src/elements.cc » ('j') | no next file with comments »