Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/crankshaft/x87/lithium-codegen-x87.cc

Issue 1409123003: [runtime] Avoid @@isConcatSpreadable lookup for fast path Array.prototype.concat (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: merging with master Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/crankshaft/x87/lithium-codegen-x87.h" 7 #include "src/crankshaft/x87/lithium-codegen-x87.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2987 matching lines...) Expand 10 before | Expand all | Expand 10 after
2998 __ cmp(result, factory()->the_hole_value()); 2998 __ cmp(result, factory()->the_hole_value());
2999 DeoptimizeIf(equal, instr, Deoptimizer::kHole); 2999 DeoptimizeIf(equal, instr, Deoptimizer::kHole);
3000 } 3000 }
3001 } else if (instr->hydrogen()->hole_mode() == CONVERT_HOLE_TO_UNDEFINED) { 3001 } else if (instr->hydrogen()->hole_mode() == CONVERT_HOLE_TO_UNDEFINED) {
3002 DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS); 3002 DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS);
3003 Label done; 3003 Label done;
3004 __ cmp(result, factory()->the_hole_value()); 3004 __ cmp(result, factory()->the_hole_value());
3005 __ j(not_equal, &done); 3005 __ j(not_equal, &done);
3006 if (info()->IsStub()) { 3006 if (info()->IsStub()) {
3007 // A stub can safely convert the hole to undefined only if the array 3007 // A stub can safely convert the hole to undefined only if the array
3008 // protector cell contains (Smi) Isolate::kArrayProtectorValid. Otherwise 3008 // protector cell contains (Smi) Isolate::kArrayProtectorValid.
3009 // it needs to bail out. 3009 // Otherwise it needs to bail out.
3010 __ mov(result, isolate()->factory()->array_protector()); 3010 __ LoadRoot(result, Heap::kArrayProtectorRootIndex);
3011 __ cmp(FieldOperand(result, PropertyCell::kValueOffset), 3011 __ cmp(FieldOperand(result, PropertyCell::kValueOffset),
3012 Immediate(Smi::FromInt(Isolate::kArrayProtectorValid))); 3012 Immediate(Smi::FromInt(Isolate::kArrayProtectorValid)));
3013 DeoptimizeIf(not_equal, instr, Deoptimizer::kHole); 3013 DeoptimizeIf(not_equal, instr, Deoptimizer::kHole);
3014 } 3014 }
3015 __ mov(result, isolate()->factory()->undefined_value()); 3015 __ mov(result, isolate()->factory()->undefined_value());
3016 __ bind(&done); 3016 __ bind(&done);
3017 } 3017 }
3018 } 3018 }
3019 3019
3020 3020
(...skipping 2863 matching lines...) Expand 10 before | Expand all | Expand 10 after
5884 __ bind(deferred->exit()); 5884 __ bind(deferred->exit());
5885 __ bind(&done); 5885 __ bind(&done);
5886 } 5886 }
5887 5887
5888 #undef __ 5888 #undef __
5889 5889
5890 } // namespace internal 5890 } // namespace internal
5891 } // namespace v8 5891 } // namespace v8
5892 5892
5893 #endif // V8_TARGET_ARCH_X87 5893 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/crankshaft/ia32/lithium-codegen-ia32.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698