Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: test/mjsunit/harmony/array-concat-object-proto-dict.js

Issue 1409123003: [runtime] Avoid @@isConcatSpreadable lookup for fast path Array.prototype.concat (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: merging with master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // Check that @@isConcatSpreadable is checked when set on Object.prototype
6 // with a dictionary backing store.
7
8 // Force Object.prototype into dictionary backing store by adding many
9 // properties.
10 for (var i = 0; i < 10*1000; i++) {
11 Object.prototype['generatedProperty'+i] = true;
12 }
13
14 var array = [1, 2, 3];
15 var object = {length: 1, '0': 'a'};
16
17 assertEquals(array, [].concat(array));
18 assertEquals(array, array.concat([]));
19 assertEquals([1, 2, 3, 1, 2, 3], array.concat(array));
20 assertEquals([object], [].concat(object));
21 assertEquals([1, 2, 3, object], array.concat(object));
22 assertEquals([object], Array.prototype.concat.call(object,[]));
23 assertEquals([object, 1, 2, 3], Array.prototype.concat.call(object, array));
24 assertEquals([object, object], Array.prototype.concat.call(object, object));
25
26 Object.prototype[Symbol.isConcatSpreadable] = false;
27
28 assertEquals([[], array], [].concat(array));
29 assertEquals([array, []], array.concat([]));
30 assertEquals([array, array], array.concat(array));
31 assertEquals([[], object], [].concat(object));
32 assertEquals([array, object], array.concat(object));
33 assertEquals([object, []], Array.prototype.concat.call(object,[]));
34 assertEquals([object, array], Array.prototype.concat.call(object, array));
35 assertEquals([object, object], Array.prototype.concat.call(object, object));
36
37 Object.prototype[Symbol.isConcatSpreadable] = true;
38
39 assertEquals(array, [].concat(array));
40 assertEquals(array, array.concat([]));
41 assertEquals([1, 2, 3, 1, 2, 3], array.concat(array));
42 assertEquals(['a'], [].concat(object));
43 assertEquals([1, 2, 3, 'a'], array.concat(object));
44 assertEquals(['a'], Array.prototype.concat.call(object,[]));
45 assertEquals(['a', 1, 2, 3], Array.prototype.concat.call(object, array));
46 assertEquals(['a', 'a'], Array.prototype.concat.call(object, object));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698