Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1409113010: Oilpan: Remove Partitions::fastStrDup (Closed)

Created:
5 years, 1 month ago by haraken
Modified:
5 years, 1 month ago
Reviewers:
hajimehoshi, tasak
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Remove Partitions::fastStrDup It is used only in XSLTProcessorLibxslt.cpp. This CL makes a static helper method for XSLTProcessorLibxslt and removes Partitions::fastStrDup. BUG=548582 Committed: https://crrev.com/857399e720b99f272fc93f66287ec8a8ae0e1937 Cr-Commit-Position: refs/heads/master@{#357059}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 1 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Partitions.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
PTAL
5 years, 1 month ago (2015-10-28 18:45:57 UTC) #2
haraken
On 2015/10/28 18:45:57, haraken wrote: > PTAL tasak@, hajimehoshi@: friendly ping :)
5 years, 1 month ago (2015-10-29 15:12:52 UTC) #4
tasak
lgtm
5 years, 1 month ago (2015-10-30 02:35:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409113010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409113010/20001
5 years, 1 month ago (2015-10-30 02:36:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 08:24:39 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 08:26:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/857399e720b99f272fc93f66287ec8a8ae0e1937
Cr-Commit-Position: refs/heads/master@{#357059}

Powered by Google App Engine
This is Rietveld 408576698