Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2067)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 1409113006: - Some cleanup of dynamic_type usage. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index 1ac848c468acdb54f2e2527ceb9e7610472b21a3..abc802ae2db9b3655a52158540f7842ac4b1d89d 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -2072,7 +2072,6 @@ void ClassFinalizer::CreateForwardingConstructors(
const String& mixin_name = String::Handle(mixin_app.Name());
const Class& super_class = Class::Handle(mixin_app.SuperClass());
const String& super_name = String::Handle(super_class.Name());
- const Type& dynamic_type = Type::Handle(Type::DynamicType());
const Array& functions = Array::Handle(super_class.functions());
const intptr_t num_functions = functions.Length();
Function& func = Function::Handle();
@@ -2105,7 +2104,7 @@ void ClassFinalizer::CreateForwardingConstructors(
clone.set_num_fixed_parameters(func.num_fixed_parameters());
clone.SetNumOptionalParameters(func.NumOptionalParameters(),
func.HasOptionalPositionalParameters());
- clone.set_result_type(dynamic_type);
+ clone.set_result_type(Object::dynamic_type());
clone.set_is_debuggable(false);
const intptr_t num_parameters = func.NumParameters();
@@ -2117,7 +2116,7 @@ void ClassFinalizer::CreateForwardingConstructors(
// The parameter types of the cloned constructor are 'dynamic'.
clone.set_parameter_types(Array::Handle(Array::New(num_parameters)));
for (intptr_t n = 0; n < num_parameters; n++) {
- clone.SetParameterTypeAt(n, dynamic_type);
+ clone.SetParameterTypeAt(n, Object::dynamic_type());
}
cloned_funcs.Add(clone);
}
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/intermediate_language.h » ('j') | runtime/vm/scopes.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698