Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409113006: - Some cleanup of dynamic_type usage. (Closed)

Created:
5 years, 2 months ago by siva
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Some cleanup of dynamic_type usage. - Avoid egregious creation of handles in Class::CreateInvocationDispatcher R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/99abe7d8837547c10e4a9cb0f37280a711554574

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -85 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 14 chunks +19 lines, -26 lines 0 comments Download
M runtime/vm/parser.cc View 18 chunks +46 lines, -43 lines 0 comments Download
M runtime/vm/scopes.h View 1 chunk +1 line, -1 line 1 comment Download
M runtime/vm/snapshot.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
5 years, 2 months ago (2015-10-21 20:34:23 UTC) #2
regis
lgtm
5 years, 2 months ago (2015-10-21 21:14:11 UTC) #3
siva
Committed patchset #1 (id:1) manually as 99abe7d8837547c10e4a9cb0f37280a711554574 (presubmit successful).
5 years, 2 months ago (2015-10-22 00:24:14 UTC) #4
Florian Schneider
5 years, 1 month ago (2015-10-27 11:49:01 UTC) #6
Message was sent while issue was closed. 
Nice cleanup!

https://chromiumcodereview.appspot.com/1409113006/diff/1/runtime/vm/scopes.h
File runtime/vm/scopes.h (right):

https://chromiumcodereview.appspot.com/1409113006/diff/1/runtime/vm/scopes.h#...
runtime/vm/scopes.h:37: ASSERT(type.IsZoneHandle() || type.IsReadOnlyHandle());
Equivalent to type.IsNotTemporaryScopedHandle().

Powered by Google App Engine
This is Rietveld 408576698