Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409113005: SkRemote: more refactoring (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRemote: more refactoring - move Client / Server definitions to .cpp - rename Client / Server to Canvas / Decoder No diffs: https://gold.skia.org/search2?issue=1409113005&unt=true&query=source_type%3Dgm&master=false&include=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/479fe776a0c31e038aec01dcf913092c5dc39596

Patch Set 1 #

Patch Set 2 : forward declares #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -339 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M src/core/SkRemote.h View 1 3 chunks +14 lines, -143 lines 0 comments Download
M src/core/SkRemote.cpp View 1 3 chunks +276 lines, -189 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409113005/1
5 years, 2 months ago (2015-10-21 18:52:09 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 19:01:17 UTC) #4
mtklein_C
5 years, 2 months ago (2015-10-21 19:22:03 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409113005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409113005/20001
5 years, 2 months ago (2015-10-21 19:24:44 UTC) #9
hal.canary
lgtm
5 years, 2 months ago (2015-10-21 19:26:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409113005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409113005/20001
5 years, 2 months ago (2015-10-21 19:29:27 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 19:34:03 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/479fe776a0c31e038aec01dcf913092c5dc39596

Powered by Google App Engine
This is Rietveld 408576698