Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1409103004: Extend Trybot list view (Closed)

Created:
5 years, 2 months ago by stephana
Modified:
5 years, 2 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds more information about the patchset to the list of trybot issues. The additions to the Rietveld API are not used here, but will be used in subsequent CLs. https://screenshot.googleplex.com/RsjssGgeNvR.png BUG=skia:4431 Committed: https://skia.googlesource.com/buildbot/+/379747a744d4a87ee5438055315cdbee7284349c

Patch Set 1 #

Patch Set 2 : Added frontend code #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -27 lines) Patch
M go/rietveld/rietveld.go View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M golden/go/db/db.go View 1 1 chunk +7 lines, -0 lines 0 comments Download
M golden/go/goldingester/goldingester.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M golden/go/goldingester/goldingester_test.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M golden/go/goldingester/testdata/dm.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M golden/go/search/trybots.go View 1 2 4 chunks +25 lines, -11 lines 0 comments Download
M golden/go/trybot/trybot.go View 1 2 3 11 chunks +15 lines, -10 lines 0 comments Download
M golden/res/imp/trybot.html View 1 2 3 4 5 3 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
stephana
5 years, 2 months ago (2015-10-19 15:38:17 UTC) #3
stephana
Updated the UI (and screenshot) based on in-person feedback from rmistry and borenet.
5 years, 2 months ago (2015-10-19 17:10:11 UTC) #5
borenet
LGTM
5 years, 2 months ago (2015-10-19 17:13:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409103004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409103004/100001
5 years, 2 months ago (2015-10-19 17:18:16 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 18:07:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/buildbot/+/379747a744d4a87ee5438055315cdbee7284...

Powered by Google App Engine
This is Rietveld 408576698