Issue 14091008: Add support for GL_EXT_multisampled_render_to_texture.

Issue 14091008: Add support for GL_EXT_multisampled_render_to_texture. (Closed)

Created:
7 years, 8 months ago by bsalomon

Modified:
7 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add support for GL_EXT_multisampled_render_to_texture. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=8939

Patch Set 2 : Add support for GL_EXT_multisampled_render_to_texture. #

Patch Set 3 : Add support for GL_EXT_multisampled_render_to_texture. #

Patch Set 6 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -35 lines)			Patch
M	src/gpu/gl/GrGLCaps.h	View	1 2 3 4 5	2 chunks	+31 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1 2 3 4 5	3 chunks	+15 lines, -11 lines	0 comments	Download
M	src/gpu/gl/GrGLInterface.cpp	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2 3 4 5	9 chunks	+17 lines, -16 lines	0 comments	Download
M	src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp	View	1 2 3 4 5	3 chunks	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + some nits https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGLCaps.h File src/gpu/gl/GrGLCaps.h (right): https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGLCaps.h#newcode164 src/gpu/gl/GrGLCaps.h:164: /** and -> an https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGpuGL.cpp ...

7 years, 7 months ago (2013-05-01 15:36:55 UTC) #3

bsalomon

Committed patchset #6 manually as r8939 (presubmit successful).

7 years, 7 months ago (2013-05-01 20:10:06 UTC) #4

bsalomon

7 years, 7 months ago (2013-05-03 13:30:53 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (right):

https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGLCaps.h#new...
src/gpu/gl/GrGLCaps.h:164: /**
On 2013/05/01 15:36:55, robertphillips wrote:
> and -> an

Done.

https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGpuGL.cpp#ne...
src/gpu/gl/GrGpuGL.cpp:783: 
On 2013/05/01 15:36:55, robertphillips wrote:
> Is there an extra space after the &&?

Done.

https://codereview.chromium.org/14091008/diff/13003/src/gpu/gl/GrGpuGL.cpp#ne...
src/gpu/gl/GrGpuGL.cpp:803: !this->configToGLFormats(desc->fConfig,
On 2013/05/01 15:36:55, robertphillips wrote:
> What's up with this indentation?

Done.

Expand Messages | Collapse Messages