Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1572)

Issue 14091006: MIPS: Generator objects can suspend (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Generator objects can suspend Port r14353 (f4bb81d1) Original commit message: * src/ast.h: * src/parser.cc: Differentiate between the different kinds of yields, in anticipation of boxing return values. Parse `return' into `yield' in a generator. * src/runtime.h: * src/runtime.cc (Runtime_SuspendJSGeneratorObject): New horrible runtime function: saves continuation, context, and operands into the generator object. * src/arm/full-codegen-arm.cc (VisitYield): * src/ia32/full-codegen-ia32.cc (VisitYield): * src/x64/full-codegen-x64.cc (VisitYield): Arrange to call SuspendJSGeneratorObject. If the call returns the hole, we suspend. Otherwise we resume. BUG=v8:2355 TEST=These codepaths are tested when the generator is first invoked, and so are covered by mjsunit/harmony/generators-objects.js. Committed: https://code.google.com/p/v8/source/detail?r=14363

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M src/mips/full-codegen-mips.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
7 years, 8 months ago (2013-04-19 19:07:51 UTC) #1
Paul Lind
Just a nit to fix.... https://codereview.chromium.org/14091006/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/14091006/diff/1/src/mips/full-codegen-mips.cc#newcode1961 src/mips/full-codegen-mips.cc:1961: JSGeneratorObject::kContinuationOffset)); nit: indentation is ...
7 years, 8 months ago (2013-04-19 19:15:15 UTC) #2
palfia
Thanks, fixed. https://codereview.chromium.org/14091006/diff/1/src/mips/full-codegen-mips.cc File src/mips/full-codegen-mips.cc (right): https://codereview.chromium.org/14091006/diff/1/src/mips/full-codegen-mips.cc#newcode1961 src/mips/full-codegen-mips.cc:1961: JSGeneratorObject::kContinuationOffset)); On 2013/04/19 19:15:15, Paul Lind wrote: ...
7 years, 8 months ago (2013-04-19 19:18:46 UTC) #3
Paul Lind
Thanks, LGTM!
7 years, 8 months ago (2013-04-19 19:20:09 UTC) #4
palfia
7 years, 8 months ago (2013-04-19 19:23:11 UTC) #5
Message was sent while issue was closed.
Committed manually as r14363 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698