Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 1409093005: Re-re-land "[es6] Implement destructuring binding in try/catch" (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-re-land "[es6] Implement destructuring binding in try/catch" http://crrev.com/80a1e004f4ef619b54a2d87bf2108719a8411860 was reverted due to a Blink test failure. That test has been marked as failing on the Blink side in https://chromium.googlesource.com/chromium/src/+/ac11c6df133. BUG=v8:811 LOG=y TBR=rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e33c4b450f58d6dd33e56263c0f64d7f79450929 Cr-Commit-Position: refs/heads/master@{#31842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -10 lines) Patch
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 3 chunks +67 lines, -7 lines 0 comments Download
M src/preparser.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + test/message/try-catch-lexical-conflict.js View 1 chunk +5 lines, -1 line 0 comments Download
A test/message/try-catch-lexical-conflict.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/try-catch-variable-conflict.js View 1 chunk +4 lines, -1 line 0 comments Download
A test/message/try-catch-variable-conflict.out View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409093005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409093005/1
5 years, 1 month ago (2015-11-05 19:46:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 20:21:23 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 20:21:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e33c4b450f58d6dd33e56263c0f64d7f79450929
Cr-Commit-Position: refs/heads/master@{#31842}

Powered by Google App Engine
This is Rietveld 408576698