Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: handler/mac/exception_handler_server.h

Issue 1409073013: mac: Make crashpad_handler get its receive right from its client (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crashpad_client_mac.cc ('k') | handler/mac/exception_handler_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/mac/exception_handler_server.h
diff --git a/handler/mac/exception_handler_server.h b/handler/mac/exception_handler_server.h
index 83e131be7c22275edeab9c9f9d5e3058c009c9ec..a057dc69f769d3d134b3a34807ff0b70a9f1395e 100644
--- a/handler/mac/exception_handler_server.h
+++ b/handler/mac/exception_handler_server.h
@@ -28,7 +28,8 @@ namespace crashpad {
//! process.
class ExceptionHandlerServer {
public:
- ExceptionHandlerServer();
+ explicit ExceptionHandlerServer(
Robert Sesek 2015/10/29 21:04:00 No comment?
Mark Mentovai 2015/10/29 21:39:58 Robert Sesek wrote:
+ base::mac::ScopedMachReceiveRight receive_port);
~ExceptionHandlerServer();
//! \brief Runs the exception-handling server.
@@ -52,13 +53,6 @@ class ExceptionHandlerServer {
//! this method will continue running normally.
void Run(UniversalMachExcServer::Interface* exception_interface);
- //! \brief Returns the receive right that will be monitored for exception
- //! messages.
- //!
- //! The caller does not take ownership of this port. The caller must not use
- //! this port for any purpose other than to make send rights for clients.
- mach_port_t receive_port() const { return receive_port_.get(); }
-
private:
base::mac::ScopedMachReceiveRight receive_port_;
« no previous file with comments | « client/crashpad_client_mac.cc ('k') | handler/mac/exception_handler_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698