mac: Make crashpad_handler get its receive right from its client

handler/mac/exception_handler_server.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 107 matching lines @@
                                    mach_msg_type_number_t code_count,
                                    thread_state_flavor_t* flavor,
                                    ConstThreadState old_state,
                                    mach_msg_type_number_t old_state_count,
                                    thread_state_t new_state,
                                    mach_msg_type_number_t* new_state_count,
                                    const mach_msg_trailer_t* trailer,
                                    bool* destroy_complex_request) override {
     if (exception_port != exception_port_) {
       LOG(WARNING) << "exception port mismatch";
-      return MIG_BAD_ID;
+      return KERN_FAILURE;
     }
 
     return exception_interface_->CatchMachException(behavior,
                                                     exception_port,
                                                     thread,
                                                     task,
                                                     exception,
                                                     code,
                                                     code_count,
                                                     flavor,
@@ skipping 26 matching lines @@
       notify_port_t notify,
       mach_port_mscount_t mscount,
       const mach_msg_trailer_t* trailer) override {
     if (notify != notify_port_) {
       // The message was received as part of a port set. This check ensures that
       // only the authorized sender of the no-senders notification is able to
       // stop the exception server. Otherwise, a malicious client would be able
       // to craft and send a no-senders notification via its exception port, and
       // cause the handler to stop processing exceptions and exit.
       LOG(WARNING) << "notify port mismatch";
-      return MIG_BAD_ID;
+      return KERN_FAILURE;
     }
 
     running_ = false;
 
     return KERN_SUCCESS;
   }
 
   kern_return_t DoMachNotifySendOnce(
       notify_port_t notify,
       const mach_msg_trailer_t* trailer) override {
     return UnimplementedNotifyRoutine(notify);
   }
 
   kern_return_t DoMachNotifyDeadName(
       notify_port_t notify,
       mach_port_name_t name,
       const mach_msg_trailer_t* trailer) override {
     return UnimplementedNotifyRoutine(notify);
   }
 
  private:
   kern_return_t UnimplementedNotifyRoutine(notify_port_t notify) {
     // Most of the routines in the notify subsystem are not expected to be
     // called.
     if (notify != notify_port_) {
       LOG(WARNING) << "notify port mismatch";
-      return MIG_BAD_ID;
+      return KERN_FAILURE;
     }
 
     NOTREACHED();
-    return KERN_FAILURE;
+    return MIG_BAD_ID;
   }
 
   UniversalMachExcServer mach_exc_server_;
   NotifyServer notify_server_;
   CompositeMachMessageServer composite_mach_message_server_;
   UniversalMachExcServer::Interface* exception_interface_;  // weak
   mach_port_t exception_port_;  // weak
   base::mac::ScopedMachReceiveRight notify_port_;
   bool running_;
 
   DISALLOW_COPY_AND_ASSIGN(ExceptionHandlerServerRun);
 };
 
 }  // namespace
 
-ExceptionHandlerServer::ExceptionHandlerServer()
-    : receive_port_(NewMachPort(MACH_PORT_RIGHT_RECEIVE)) {
+ExceptionHandlerServer::ExceptionHandlerServer(
+    base::mac::ScopedMachReceiveRight receive_port)
+    : receive_port_(receive_port.Pass()) {
   CHECK(receive_port_.is_valid());
 }
 
 ExceptionHandlerServer::~ExceptionHandlerServer() {
 }
 
 void ExceptionHandlerServer::Run(
     UniversalMachExcServer::Interface* exception_interface) {
   ExceptionHandlerServerRun run(receive_port_.get(), exception_interface);
   run.Run();
 }
 
 }  // namespace crashpad