blimp: Override RequestPermissions in BlimpPermissionManager.

blimp: Override RequestPermissions in BlimpPermissionManager.

content::PermissionManager is an abstract class, i.e. contains only pure
virtual methods and thus all methods should be overridden otherwise
things won't compile.

BUG=None
R=kmarshall@chromium.org,dtrainor@chromium.org

Committed: https://crrev.com/166199081e69bf582a4d75339827a81563bfc0c2
Cr-Commit-Position: refs/heads/master@{#356149}

[tfarina, 2015-10-25 00:35:25]

PTAL!

I found this when I ran 'ninja -C out-gn/Release'

[tfarina, 2015-10-26 20:55:38]

Ping?

[David Trainor- moved to gerrit, 2015-10-26 21:40:07]

dtrainor@chromium.org changed reviewers:
+ dtrainor@chromium.org

[David Trainor- moved to gerrit, 2015-10-26 21:40:07]

lgtm thanks for fixing the compile issue! :)

[tfarina, 2015-10-26 21:43:05]

Description was changed from

==========
blimp: Override RequestPermissions in BlimpPermissionManager.

content::PermissionManager is an abstract class, i.e. contains only pure
virtual methods and thus all methods should be overridden otherwise
things won't compile.

BUG=None
R=kmarshall@chromium.org
==========

to

==========
blimp: Override RequestPermissions in BlimpPermissionManager.

content::PermissionManager is an abstract class, i.e. contains only pure
virtual methods and thus all methods should be overridden otherwise
things won't compile.

BUG=None
R=kmarshall@chromium.org,dtrainor@chromium.org
==========

[tfarina, 2015-10-26 21:43:10]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-10-26 21:43:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409073008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409073008/1

[commit-bot: I haz the power, 2015-10-26 22:17:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-26 22:18:41]

Patchset 1 (id:??) landed as
https://crrev.com/166199081e69bf582a4d75339827a81563bfc0c2
Cr-Commit-Position: refs/heads/master@{#356149}