Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: test/cctest/test-api-interceptors.cc

Issue 1409073005: [runtime] use std::vector in KeyAccumulator (Closed)
Patch Set: typo Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-array.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api-interceptors.cc
diff --git a/test/cctest/test-api-interceptors.cc b/test/cctest/test-api-interceptors.cc
index f0ec349c2e28c49eccccd06d251e0c978de3ab20..39f9e901137e987c1bf1d7cda4949e9aaca0c5d2 100644
--- a/test/cctest/test-api-interceptors.cc
+++ b/test/cctest/test-api-interceptors.cc
@@ -2010,16 +2010,14 @@ THREADED_TEST(Enumerators) {
// This order is not mandated by the spec, so this test is just
// documenting our behavior.
CHECK_EQ(17u, result->Length());
- // Indexed properties in numerical order.
- CHECK(v8_str("5")->Equals(result->Get(v8::Integer::New(isolate, 0))));
- CHECK(v8_str("10")->Equals(result->Get(v8::Integer::New(isolate, 1))));
- CHECK(v8_str("140000")->Equals(result->Get(v8::Integer::New(isolate, 2))));
+ // Indexed properties + indexed interceptor properties in numerical order.
+ CHECK(v8_str("0")->Equals(result->Get(v8::Integer::New(isolate, 0))));
+ CHECK(v8_str("1")->Equals(result->Get(v8::Integer::New(isolate, 1))));
+ CHECK(v8_str("5")->Equals(result->Get(v8::Integer::New(isolate, 2))));
+ CHECK(v8_str("10")->Equals(result->Get(v8::Integer::New(isolate, 3))));
+ CHECK(v8_str("140000")->Equals(result->Get(v8::Integer::New(isolate, 4))));
CHECK(
- v8_str("4294967294")->Equals(result->Get(v8::Integer::New(isolate, 3))));
- // Indexed interceptor properties in the order they are returned
- // from the enumerator interceptor.
- CHECK(v8_str("0")->Equals(result->Get(v8::Integer::New(isolate, 4))));
- CHECK(v8_str("1")->Equals(result->Get(v8::Integer::New(isolate, 5))));
+ v8_str("4294967294")->Equals(result->Get(v8::Integer::New(isolate, 5))));
// Named properties in insertion order.
CHECK(v8_str("a")->Equals(result->Get(v8::Integer::New(isolate, 6))));
CHECK(v8_str("b")->Equals(result->Get(v8::Integer::New(isolate, 7))));
« no previous file with comments | « src/runtime/runtime-array.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698