[runtime] use std::vector in KeyAccumulator

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 
 #include "src/allocation.h"
@@ skipping 10736 matching lines @@
 // Only unique keys are kept by the KeyAccumulator, strings are stored in a
 // HashSet for inexpensive lookups. Integer keys are kept in sorted lists which
 // are more compact and allow for reasonably fast includes check.
 class KeyAccumulator final BASE_EMBEDDED {
  public:
   explicit KeyAccumulator(Isolate* isolate,
                           KeyFilter filter = KeyFilter::SKIP_SYMBOLS)
       : isolate_(isolate), filter_(filter), length_(0), levelLength_(0) {}
   ~KeyAccumulator();
 
+  enum ElementKeyAddCheckLimit { EXCLUDE_CURRENT_LEVEL, INCLUDE_CURRENT_LEVEL };
+
   bool AddKey(uint32_t key);
   bool AddKey(Object* key, AddKeyConversion convert = DO_NOT_CONVERT);
   bool AddKey(Handle<Object> key, AddKeyConversion convert = DO_NOT_CONVERT);
   void AddKeys(Handle<FixedArray> array,
                AddKeyConversion convert = DO_NOT_CONVERT);
   void AddKeys(Handle<JSObject> array,
                AddKeyConversion convert = DO_NOT_CONVERT);
   void AddKeysFromProxy(Handle<JSObject> array);
+  void AddKeysFromInterceptor(Handle<JSObject> array);
   // Jump to the next level, pushing the current |levelLength_| to
   // |levelLengths_| and adding a new list to |elements_|.
   void NextPrototype();
   // Sort the integer indices in the last list in |elements_|
   void SortCurrentElementsList();
   Handle<FixedArray> GetKeys(GetKeysConversion convert = KEEP_NUMBERS);
 
 
  private:
   Isolate* isolate_;
   KeyFilter filter_;
   // |elements_| contains the sorted element keys (indices) per level.
-  List<List<uint32_t>*> elements_;
+  std::vector<std::vector<uint32_t>*> elements_;

[Igor Sheludko, 2015/10/22 21:42:57]

Suggestion: use std::unique_ptr:
  std::vector<std::unique_ptr<std::vector<uint32_t>>> elements_;
In this case you can remove destructor.

[Camillo Bruni, 2015/10/23 08:56:35]

I think I prefer not using smart pointers since we do not leak any objects, if
that is fine with you?

   // |protoLengths_| contains the total number of keys (elements + properties)
   // per level. Negative values mark counts for a level with keys from a proxy.
-  List<int> levelLengths_;
+  std::vector<int> levelLengths_;
   // |properties_| contains the property keys per level in insertion order.
   Handle<OrderedHashSet> properties_;
   // |length_| keeps track of the total number of all element and property keys.
   int length_;
   // |levelLength_| keeps track of the total number of keys
   // (elements + properties) in the current level.
   int levelLength_;
+  // Indicate where to stop looking for duplicates when adding new element keys.
+  ElementKeyAddCheckLimit elementKeysAddCheckLimit_ = EXCLUDE_CURRENT_LEVEL;

[Igor Sheludko, 2015/10/22 21:42:57]

Nice! What about initializing lengths fields this way?

[Camillo Bruni, 2015/10/23 08:56:35]

done

 
   DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);
 };
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_