third_party/WebKit/Source/core/editing/Editor.h - Issue 1409073004: Return EphemeralRange from Editor::findRangeOfString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.h

Issue 1409073004: Return EphemeralRange from Editor::findRangeOfString. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Extract text bounds collecting to a function Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.h

diff --git a/third_party/WebKit/Source/core/editing/Editor.h b/third_party/WebKit/Source/core/editing/Editor.h

index dc631f14891633c9e29093b5f8250c8960c9ba1c..a765b9a1331ddca635638e2c46c19f63be5efc7a 100644

--- a/third_party/WebKit/Source/core/editing/Editor.h

+++ b/third_party/WebKit/Source/core/editing/Editor.h

@@ -202,9 +202,10 @@ public:

bool findString(const String&, FindOptions);

- PassRefPtrWillBeRawPtr<Range> findStringAndScrollToVisible(const String&, Range*, FindOptions);

- PassRefPtrWillBeRawPtr<Range> findRangeOfString(const String& target, const EphemeralRange& referenceRange, FindOptions);

- PassRefPtrWillBeRawPtr<Range> findRangeOfString(const String& target, const EphemeralRangeInComposedTree& referenceRange, FindOptions);

+ EphemeralRange findStringAndScrollToVisible(const String&, const EphemeralRange&, FindOptions);

+ EphemeralRangeInComposedTree findStringAndScrollToVisible(const String&, const EphemeralRangeInComposedTree&, FindOptions);

+ EphemeralRange findRangeOfString(const String& target, const EphemeralRange& referenceRange, FindOptions);

+ EphemeralRangeInComposedTree findRangeOfString(const String& target, const EphemeralRangeInComposedTree& referenceRange, FindOptions);

const VisibleSelection& mark() const; // Mark, to be used as emacs uses it.

void setMark(const VisibleSelection&);