Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 1409073004: Return EphemeralRange from Editor::findRangeOfString. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Extract text bounds collecting to a function Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 { 322 {
323 // These are characters that can behave as word boundaries, but can appear w ithin words. 323 // These are characters that can behave as word boundaries, but can appear w ithin words.
324 // If they are just typed, i.e. if they are immediately followed by a caret, we want to delay text checking until the next character has been typed. 324 // If they are just typed, i.e. if they are immediately followed by a caret, we want to delay text checking until the next character has been typed.
325 // FIXME: this is required until 6853027 is fixed and text checking can do t his for us. 325 // FIXME: this is required until 6853027 is fixed and text checking can do t his for us.
326 return character == '\'' || character == rightSingleQuotationMarkCharacter | | character == hebrewPunctuationGershayimCharacter; 326 return character == '\'' || character == rightSingleQuotationMarkCharacter | | character == hebrewPunctuationGershayimCharacter;
327 } 327 }
328 328
329 String stringWithRebalancedWhitespace(const String&, bool startIsStartOfParagrap h, bool endIsEndOfParagraph); 329 String stringWithRebalancedWhitespace(const String&, bool startIsStartOfParagrap h, bool endIsEndOfParagraph);
330 const String& nonBreakingSpaceString(); 330 const String& nonBreakingSpaceString();
331 331
332 void collectTextBoundsInRange(
333 Node* start, int startOffset, Node* end, int endOffset, Node* firstNode, Nod e* stopNode, Node* (*next)(const Node&),
334 Vector<IntRect>& rects, bool useSelectionHeight = false, bool* allFixed = nu llptr, bool* someFixed = nullptr);
335
336 void collectTextBoundsInRange(
337 Node* start, int startOffset, Node* end, int endOffset, Node* firstNode, Nod e* stopNode, Node* (*next)(const Node&),
338 Vector<FloatQuad>& rects, bool useSelectionHeight = false, bool* allFixed = nullptr, bool* someFixed = nullptr);
339
340 template <typename Strategy, typename BoundsType>
341 void collectTextBoundsInRange(
342 const PositionTemplate<Strategy>& start, const PositionTemplate<Strategy>& e nd, Node* firstNode, Node* stopNode,
343 Vector<BoundsType>& bounds, bool useSelectionHeight = false, bool* allFixed = nullptr, bool* someFixed = nullptr)
344 {
345 collectTextBoundsInRange(
346 start.computeContainerNode(), start.computeOffsetInContainerNode(),
347 end.computeContainerNode(), end.computeOffsetInContainerNode(), firstNod e, stopNode,
348 &Strategy::next, bounds, useSelectionHeight, allFixed, someFixed);
349 }
350
332 } 351 }
333 352
334 #endif 353 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698