Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1409063008: Replace newString() with stringPointer() or just &s where the compiler allows this. (Closed)

Created:
5 years, 1 month ago by rudominer
Modified:
5 years, 1 month ago
Reviewers:
mattr, azani
CC:
mattr, mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Replace newString() with stringPointer() or just &s where the compiler allows this. This addresses a post-commit remark by mattr@ in https://codereview.chromium.org/1421193003/. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2d6a5148eaad734548f387a92c473e6fc28c2d8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M mojom/mojom_parser/serialization/serialization.go View 5 chunks +13 lines, -13 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rudominer
ptal
5 years, 1 month ago (2015-11-11 00:16:59 UTC) #4
azani
lgtm
5 years, 1 month ago (2015-11-11 00:18:05 UTC) #5
rudominer
Committed patchset #1 (id:1) manually as 2d6a5148eaad734548f387a92c473e6fc28c2d8e (presubmit successful).
5 years, 1 month ago (2015-11-11 00:18:46 UTC) #6
mattr
5 years, 1 month ago (2015-11-11 00:21:44 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698