Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1409063004: Fix -webkit-column-span isValueID ASSERT (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix -webkit-column-span isValueID ASSERT In r356767 I changed consumeInteger to generate CSSPrimitiveValue's of type Integer, however CSSPrimitveValueMappings.h still assumes Number, so change that assumption to Integer. BUG=549560 Committed: https://crrev.com/7a85c51eeb048304c25f82d35e814165bc2175c2 Cr-Commit-Position: refs/heads/master@{#358221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/webkit-column-span-legacy.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/webkit-column-span-legacy-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL.
5 years, 1 month ago (2015-11-05 21:16:50 UTC) #4
Timothy Loh
On 2015/11/05 21:16:50, rwlbuis wrote: > PTAL. lgtm
5 years, 1 month ago (2015-11-05 23:59:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409063004/1
5 years, 1 month ago (2015-11-06 00:18:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 01:28:41 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 01:29:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a85c51eeb048304c25f82d35e814165bc2175c2
Cr-Commit-Position: refs/heads/master@{#358221}

Powered by Google App Engine
This is Rietveld 408576698