sdk/lib/convert/ascii.dart - Issue 1409053007: More optimization of _uriEncode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/convert/ascii.dart

Issue 1409053007: More optimization of _uriEncode. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Call directly to specialized UTF-8 version. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/convert/ascii.dart

diff --git a/sdk/lib/convert/ascii.dart b/sdk/lib/convert/ascii.dart

index c8b59037711f2c08d9ada6fc4877076f8c8247d4..3f86852ac4a062a663b657abebf4de5fb11b8f26 100644

--- a/sdk/lib/convert/ascii.dart

+++ b/sdk/lib/convert/ascii.dart

@@ -290,7 +290,8 @@ class _SimpleAsciiDecoderSink extends ByteConversionSinkBase {

void add(List<int> source) {

for (int i = 0; i < source.length; i++) {

if ((source[i] & ~_ASCII_MASK) != 0) {

- throw new FormatException("Source contains non-ASCII bytes.");

+ throw new FormatException("Source contains non-ASCII bytes.",

+ source, i);

}

_sink.add(new String.fromCharCodes(source));

« no previous file with comments | « no previous file | sdk/lib/core/core.dart » ('j') | sdk/lib/core/uri.dart » ('J')