Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1409053006: Create a new data structure StreamSequencerBuffer for QuicStreamSequencer. Currently QuicStreamSequ… (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@106492030
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a new data structure StreamSequencerBuffer for QuicStreamSequencer. Currently QuicStreamSequencer is using std::list to store frames, which could buffer a series of tiny stream frames if the frames arrive so. And they are read out independently as very small strings never coalesced. StreamSequencerBuffer coalesce these small strings and read them out as a whole. It is a circular stream buffer with random write and in-sequence read. It consists of an array of pointers pointing to memory block de/allocated using new/delete and a list of GapRange objects to indicate the missing data between the data already been written into the buffer. And it keeps tracking the total bytes having been read out. Merge internal change: 106593539 R=rtennet@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1635 lines, -1 line) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer_buffer_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
A net/quic/stream_sequencer_buffer.h View 1 chunk +200 lines, -0 lines 0 comments Download
A net/quic/stream_sequencer_buffer.cc View 1 chunk +452 lines, -0 lines 0 comments Download
A net/quic/stream_sequencer_buffer_test.cc View 1 chunk +980 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (2 generated)
Ryan Hamilton
5 years, 1 month ago (2015-11-02 22:33:46 UTC) #1
ramant (doing other things)
5 years, 1 month ago (2015-11-03 00:30:26 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698