Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1409053003: skia: Make the validate match interface for *_draw_instanced (Closed)

Created:
5 years, 2 months ago by hendrikw
Modified:
5 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia: Make the validate match interface for *_draw_instanced For whatever reason, on the Mac, the command buffer is reporting ARB_draw_instanced as a valid extension. This is probably a bug in the command buffer and I'll look into this later. In Skia, we don't check for ARB_draw_instanced in GLES2 when building the interface, but during the validate, we do, so we ended up failing the validation. Looking a bit further at the specs, ARB_draw_instanced is GL only, whereas EXT_draw_instanced is both GL and GLES. I've updated the code to reflect this. See: https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/specs/ARB/draw_instanced.txt https://www.opengl.org/registry/specs/EXT/draw_instanced.txt Everything above also applies to ARB/EXT_instanced_arrays https://www.khronos.org/registry/gles/extensions/EXT/EXT_instanced_arrays.txt https://www.opengl.org/registry/specs/ARB/instanced_arrays.txt Committed: https://skia.googlesource.com/skia/+/b3f1636ec80e66188ddc01306672a9a79a954dfe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +27 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hendrikw
PTAL, thanks!
5 years, 2 months ago (2015-10-16 23:34:23 UTC) #2
bsalomon
5 years, 2 months ago (2015-10-19 13:04:02 UTC) #3
bsalomon
On 2015/10/19 13:04:02, bsalomon wrote: lgtm
5 years, 2 months ago (2015-10-19 13:04:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409053003/1
5 years, 2 months ago (2015-10-19 13:04:22 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 13:13:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b3f1636ec80e66188ddc01306672a9a79a954dfe

Powered by Google App Engine
This is Rietveld 408576698