Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1409033006: Add missing generated headers in generated_modules_dictionary_files (Closed)

Created:
5 years, 1 month ago by bashi
Modified:
5 years, 1 month ago
Reviewers:
haraken, ortuno
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing generated headers in generated_modules_dictionary_files Missing these header files cause unclean builds. TBR=haraken BUG=548915 Committed: https://crrev.com/05fe05b308cab1533d8dced240a0f1a036d89edc Cr-Commit-Position: refs/heads/master@{#357048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409033006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409033006/1
5 years, 1 month ago (2015-10-30 00:53:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/128027)
5 years, 1 month ago (2015-10-30 03:05:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409033006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409033006/1
5 years, 1 month ago (2015-10-30 03:58:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 05:03:34 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 05:04:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05fe05b308cab1533d8dced240a0f1a036d89edc
Cr-Commit-Position: refs/heads/master@{#357048}

Powered by Google App Engine
This is Rietveld 408576698