Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409033005: Add @anonymous annotation and restrict object literal constructors to only anonymous classes. This … (Closed)

Created:
5 years, 1 month ago by Jacob
Modified:
5 years, 1 month ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add @anonymous annotation and restrict object literal constructors to only anonymous classes. This frees up defining factory constructors that do not correspond to object literals on JS interop classes. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/e0d2263bb3b77e20b319a539cfefe3e8a76a2d5c

Patch Set 1 #

Patch Set 2 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -13 lines) Patch
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +47 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 3 chunks +49 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 4 chunks +14 lines, -10 lines 0 comments Download
M pkg/js/lib/js.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/js/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_typed_interop_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jacob
5 years, 1 month ago (2015-10-30 00:09:05 UTC) #2
sra1
lgtm
5 years, 1 month ago (2015-10-30 00:29:16 UTC) #3
Jacob
ptal. Small refactor pushing more code into js_interop_analysis.dart. Fixed a test failure due to ssa.dart ...
5 years, 1 month ago (2015-10-30 01:23:57 UTC) #4
Jacob
Committed patchset #2 (id:20001) manually as e0d2263bb3b77e20b319a539cfefe3e8a76a2d5c (presubmit successful).
5 years, 1 month ago (2015-10-30 02:18:23 UTC) #5
kevmoo
5 years, 1 month ago (2015-10-30 16:11:01 UTC) #6
Message was sent while issue was closed. 
On 2015/10/30 02:18:23, Jacob wrote:
> Committed patchset #2 (id:20001) manually as
> e0d2263bb3b77e20b319a539cfefe3e8a76a2d5c (presubmit successful).

Is both @JS *and* @annonymous required?

Could we just use @annonymous? – two seems redundant

Powered by Google App Engine
This is Rietveld 408576698