Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1409033003: Revise use_system_harfbuzz logic (Closed)

Created:
5 years, 2 months ago by lanechr
Modified:
5 years, 2 months ago
Reviewers:
jamesr, cstout, cdotstout
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revise use_system_harfbuzz logic Why: running pkg-config during declare_args is nasty (since it always runs, regardless of arg overrides). Also, we don't have chrome_os or official builds, and we can just declare to use it for is_linux but not fnl. BUG= R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5c647eba3d25d5e78e6d2e46c26390f6ee0f597d

Patch Set 1 #

Total comments: 2

Patch Set 2 : is_fnl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M third_party/harfbuzz-ng/BUILD.gn View 1 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lanechr
5 years, 2 months ago (2015-10-20 23:56:07 UTC) #2
jamesr
lgtm https://codereview.chromium.org/1409033003/diff/1/third_party/harfbuzz-ng/BUILD.gn File third_party/harfbuzz-ng/BUILD.gn (right): https://codereview.chromium.org/1409033003/diff/1/third_party/harfbuzz-ng/BUILD.gn#newcode16 third_party/harfbuzz-ng/BUILD.gn:16: use_system_harfbuzz = is_linux && target_os != "fnl" we ...
5 years, 2 months ago (2015-10-21 00:25:47 UTC) #3
cdotstout
https://codereview.chromium.org/1409033003/diff/1/third_party/harfbuzz-ng/BUILD.gn File third_party/harfbuzz-ng/BUILD.gn (right): https://codereview.chromium.org/1409033003/diff/1/third_party/harfbuzz-ng/BUILD.gn#newcode16 third_party/harfbuzz-ng/BUILD.gn:16: use_system_harfbuzz = is_linux && target_os != "fnl" On 2015/10/21 ...
5 years, 2 months ago (2015-10-21 00:35:53 UTC) #5
lanechr
On 2015/10/21 00:35:53, cdotstout wrote: > https://codereview.chromium.org/1409033003/diff/1/third_party/harfbuzz-ng/BUILD.gn > File third_party/harfbuzz-ng/BUILD.gn (right): > > https://codereview.chromium.org/1409033003/diff/1/third_party/harfbuzz-ng/BUILD.gn#newcode16 > ...
5 years, 2 months ago (2015-10-21 00:37:47 UTC) #6
lanechr
5 years, 2 months ago (2015-10-21 18:50:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5c647eba3d25d5e78e6d2e46c26390f6ee0f597d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698