Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 140903005: [GCM] Plumb mock keychain status to gcm store impl (Closed)

Created:
6 years, 11 months ago by Nicolas Zea
Modified:
6 years, 11 months ago
Reviewers:
jianli, fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

[GCM] Plumb mock keychain status to gcm store impl The UseMockKeychain call must be done from within the same library as the encryptor is used. To get around this we pass the mock status as a parameter at construction time. BUG=284553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246274

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M google_apis/gcm/engine/gcm_store_impl.h View 1 chunk +2 lines, -1 line 1 comment Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/user_list_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nicolas Zea
PTAL. Keychain had been prompting on mac, and this needs to be fixed before we ...
6 years, 11 months ago (2014-01-17 01:54:59 UTC) #1
jianli
lgtm https://codereview.chromium.org/140903005/diff/20001/google_apis/gcm/engine/gcm_store_impl.h File google_apis/gcm/engine/gcm_store_impl.h (right): https://codereview.chromium.org/140903005/diff/20001/google_apis/gcm/engine/gcm_store_impl.h#newcode26 google_apis/gcm/engine/gcm_store_impl.h:26: GCMStoreImpl(bool use_mock_keychain, Better do this via a separate ...
6 years, 11 months ago (2014-01-17 22:47:17 UTC) #2
fgorski
lgtm
6 years, 11 months ago (2014-01-18 00:13:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/140903005/20001
6 years, 11 months ago (2014-01-21 22:12:31 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=249327
6 years, 11 months ago (2014-01-22 00:47:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/140903005/20001
6 years, 11 months ago (2014-01-22 00:54:18 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 10:32:08 UTC) #7
Message was sent while issue was closed.
Change committed as 246274

Powered by Google App Engine
This is Rietveld 408576698