|
|
Created:
6 years, 11 months ago by ziran.sun Modified:
6 years, 9 months ago CC:
chromium-reviews, tkent Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionAdd autofill preview support for <month> input fields
Update preview functions to include case for <month> field.
Update tests accordingly.
BUG=335212
R=isherman@chromium.org, jhawkins@chromium.org, tkent@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254464
Patch Set 1 #Patch Set 2 : Reupload again - a try for "Side-to-side diffs" view issue #Patch Set 3 : Rebase to latest code base #Patch Set 4 : Reabase to revision 254451 #
Messages
Total messages: 28 (0 generated)
Please review this in conjunction with https://codereview.chromium.org/130213005/ BTW, the "Side-by-side diffs" doesn't seem working for me for this issue. Do let me know if it happens to you as well or you know a solution. Many thanks!
Re-uploaded the code. "Side-by-side diffs" view is fixed now. Thanks!
LGTM, thanks :) (Though you'll need to land the Blink-side changes first, of course.)
The CQ bit was checked by ziran.sun@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/310001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by ziran.sun@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/310001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel
The CQ bit was checked by ziran.sun@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/380001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
Looks like the "FormAutofillTest.PreviewForm" browser test is failing.
The CQ bit was checked by isherman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/380001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
The CQ bit was checked by isherman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/380001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
Ziran, please try rebasing and uploading a new patch set, then checking the CQ bit again.
The CQ bit was checked by ziran.sun@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/400001
Message was sent while issue was closed.
Change committed as 254464 |