Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 140903004: Add autofill preview support for <month> input fields (Closed)

Created:
6 years, 11 months ago by ziran.sun
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tkent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add autofill preview support for <month> input fields Update preview functions to include case for <month> field. Update tests accordingly. BUG=335212 R=isherman@chromium.org, jhawkins@chromium.org, tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254464

Patch Set 1 #

Patch Set 2 : Reupload again - a try for "Side-to-side diffs" view issue #

Patch Set 3 : Rebase to latest code base #

Patch Set 4 : Reabase to revision 254451 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
ziran.sun
Please review this in conjunction with https://codereview.chromium.org/130213005/ BTW, the "Side-by-side diffs" doesn't seem working for ...
6 years, 11 months ago (2014-01-16 19:51:24 UTC) #1
ziran.sun
Re-uploaded the code. "Side-by-side diffs" view is fixed now. Thanks!
6 years, 11 months ago (2014-01-17 09:54:38 UTC) #2
Ilya Sherman
LGTM, thanks :) (Though you'll need to land the Blink-side changes first, of course.)
6 years, 10 months ago (2014-02-08 01:15:10 UTC) #3
ziran.sun
The CQ bit was checked by ziran.sun@samsung.com
6 years, 10 months ago (2014-02-26 22:45:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/310001
6 years, 10 months ago (2014-02-26 22:46:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 23:19:17 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=270823
6 years, 10 months ago (2014-02-26 23:19:17 UTC) #7
ziran.sun
The CQ bit was checked by ziran.sun@samsung.com
6 years, 9 months ago (2014-02-27 16:49:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/310001
6 years, 9 months ago (2014-02-27 16:49:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 17:58:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-02-27 17:58:57 UTC) #11
ziran.sun
The CQ bit was checked by ziran.sun@samsung.com
6 years, 9 months ago (2014-02-27 18:20:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/380001
6 years, 9 months ago (2014-02-27 18:24:25 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 18:55:46 UTC) #14
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=52501
6 years, 9 months ago (2014-02-27 18:55:47 UTC) #15
Ilya Sherman
Looks like the "FormAutofillTest.PreviewForm" browser test is failing.
6 years, 9 months ago (2014-02-27 22:17:48 UTC) #16
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 9 months ago (2014-02-28 21:25:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/380001
6 years, 9 months ago (2014-02-28 21:27:20 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 21:28:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 9 months ago (2014-02-28 21:28:01 UTC) #20
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 9 months ago (2014-02-28 21:28:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/380001
6 years, 9 months ago (2014-02-28 21:30:11 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 21:31:54 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 9 months ago (2014-02-28 21:31:55 UTC) #24
Ilya Sherman
Ziran, please try rebasing and uploading a new patch set, then checking the CQ bit ...
6 years, 9 months ago (2014-02-28 22:01:52 UTC) #25
ziran.sun
The CQ bit was checked by ziran.sun@samsung.com
6 years, 9 months ago (2014-03-03 11:18:38 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/140903004/400001
6 years, 9 months ago (2014-03-03 11:18:44 UTC) #27
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 15:09:17 UTC) #28
Message was sent while issue was closed.
Change committed as 254464

Powered by Google App Engine
This is Rietveld 408576698