Issue 140903002: Hide bitmap rowbyes assert when LEGACY_ONLOCKPIXELS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140903002: Hide bitmap rowbyes assert when LEGACY_ONLOCKPIXELS (Closed)

Created:
6 years, 11 months ago by hal.canary

Modified:
6 years, 11 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Hide bitmap rowbyes assert when LEGACY_ONLOCKPIXELS Motivation: without this, we break Blink. BUG=skia: NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13107

Patch Set 2 : format #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/core/SkBitmap.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nit https://codereview.chromium.org/140903002/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/140903002/diff/1/src/core/SkBitmap.cpp#newcode1603 src/core/SkBitmap.cpp:1603: SkASSERT(fPixelRef->isLocked()); left align?

6 years, 11 months ago (2014-01-16 15:09:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/140903002/50001

6 years, 11 months ago (2014-01-16 15:10:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/140903002/50001

6 years, 11 months ago (2014-01-16 15:40:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/140903002/50001

6 years, 11 months ago (2014-01-16 15:46:49 UTC) #5

Message was sent while issue was closed.

Change committed as 13107

Expand Messages | Collapse Messages

Issue 140903002: Hide bitmap rowbyes assert when LEGACY_ONLOCKPIXELS (Closed)

Description

Patch Set 1 #

Patch Set 2 : format #

Messages