Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1409023002: Revert of Add webusb permission bubble mojom (Closed)

Created:
5 years, 2 months ago by Mark P
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webusb_permission_ui_1_refactor_permission_bubble_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add webusb permission bubble mojom (patchset #3 id:40001 of https://codereview.chromium.org/1404213004/ ) Reason for revert: Causes compile failure on Windows builder: http://build.chromium.org/p/chromium/builders/Win/builds/36553 c:\b\build\slave\win\build\src\out\release\gen\components\webusb\public\interfaces\webusb_permission_bubble.mojom-internal.h(13) : fatalerror C1083: Cannot open include file: 'device/devices_app/usb/public/interfaces/device.mojom-internal.h': No such file or directory Original issue's description: > Add webusb permission bubble mojom > > This patch added webusb permission bubble mojom. > It has function GetPermission to get a device after > user has granted permission to it. And this function > is used by class WebUSBClientImpl. > > BUG=492204 > > Committed: https://crrev.com/9e3fbccf392bc87e66424051e94978d7802bba0e > Cr-Commit-Position: refs/heads/master@{#354442} TBR=reillyg@chromium.org,nick@chromium.org,tsepez@chromium.org,juncai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492204 Committed: https://crrev.com/eb99c7158258a20b1bda6873ee1ab7f2a7d5394b Cr-Commit-Position: refs/heads/master@{#354443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -121 lines) Patch
M components/webusb.gypi View 2 chunks +0 lines, -23 lines 0 comments Download
M components/webusb/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/webusb/public/interfaces/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D components/webusb/public/interfaces/webusb_permission_bubble.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
D content/child/mojo/type_converters.h View 1 chunk +0 lines, -20 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/usb/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/usb/web_usb_client_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/usb/web_usb_client_impl.cc View 3 chunks +3 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark P
Created Revert of Add webusb permission bubble mojom
5 years, 2 months ago (2015-10-16 04:26:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409023002/1
5 years, 2 months ago (2015-10-16 04:27:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 04:28:01 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 04:28:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb99c7158258a20b1bda6873ee1ab7f2a7d5394b
Cr-Commit-Position: refs/heads/master@{#354443}

Powered by Google App Engine
This is Rietveld 408576698