Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: src/js/harmony-regexp.js

Issue 1409013006: Revert of Implement flag and source getters on RegExp.prototype. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rproto
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | src/js/macros.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/harmony-regexp.js
diff --git a/src/js/harmony-regexp.js b/src/js/harmony-regexp.js
index a02aa7bda495356931974424cee242a170d90e6e..033ee2c9a513abecf05a9dbc4b67571fb3a3d516 100644
--- a/src/js/harmony-regexp.js
+++ b/src/js/harmony-regexp.js
@@ -11,7 +11,6 @@
// -------------------------------------------------------------------
// Imports
-var GetRegExpFlagGetter = utils.ImportNow("GetRegExpFlagGetter");
var GlobalRegExp = global.RegExp;
var MakeTypeError;
@@ -25,8 +24,7 @@
// + https://bugs.ecmascript.org/show_bug.cgi?id=3423
function RegExpGetFlags() {
if (!IS_SPEC_OBJECT(this)) {
- throw MakeTypeError(
- kRegExpNonObject, "RegExp.prototype.flags", TO_STRING(this));
+ throw MakeTypeError(kFlagsGetterNonObject, TO_STRING(this));
}
var result = '';
if (this.global) result += 'g';
@@ -41,11 +39,4 @@
RegExpGetFlags, null, DONT_ENUM);
%SetNativeFlag(RegExpGetFlags);
-%DefineGetterPropertyUnchecked(GlobalRegExp.prototype, "sticky",
- GetRegExpFlagGetter("RegExp.prototype.sticky", REGEXP_STICKY_MASK),
- DONT_ENUM);
-
-%DefineGetterPropertyUnchecked(GlobalRegExp.prototype, "unicode",
- GetRegExpFlagGetter("RegExp.prototype.unicode", REGEXP_UNICODE_MASK),
- DONT_ENUM);
})
« no previous file with comments | « src/heap/heap.h ('k') | src/js/macros.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698