Add base test for RebuildCrossRef function.

core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp
diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp
index 827d1cec286a07ebe86f10fa01410c2d7edca7b4..5e4aee0440c189dc8e5d91f1b93e1ee36a0352d4 100644
--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp
+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp
@@ -5,6 +5,26 @@
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include "../../../include/fpdfapi/fpdf_parser.h"
+#include "../../../include/fxcrt/fx_stream.h"
+
+class CPDF_TestParser : public CPDF_Parser {
+ public:
+  CPDF_TestParser() {}
+  ~CPDF_TestParser() {}
+
+  bool InitTest(const FX_CHAR* path) {
+    IFX_FileRead* pFileAccess = FX_CreateFileRead(path);
+    if (!pFileAccess)
+      return false;
+
+    // For the test file, the header is set at the beginning.
+    m_Syntax.InitParser(pFileAccess, 0);
+    return true;
+  }
+
+ private:
+  FRIEND_TEST(fpdf_parser_parser, RebuildCrossRefCorrectly);

[Lei Zhang, 2015/11/04 18:04:26]

If you provide public CPDF_TestParser getter methods to return |m_CrossRef| and
|m_ObjVersion|, then you don't need to be friends.

[Wei Li, 2015/11/04 18:47:03]

Yes, I also need to provide a public wrapper for BuildCrossRefs(). Later, if we
decide to check other protected/private variables or functions, we need to add
all of them. WDYT?

+};
 
 // TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal.
 // Come up or wait for something better.
@@ -168,3 +188,22 @@ TEST(fpdf_parser_parser, ReadHexString) {
     EXPECT_EQ(1, parser.SavePos());
   }
 }
+
+TEST(fpdf_parser_parser, RebuildCrossRefCorrectly) {
+  CPDF_TestParser parser;
+  ASSERT_TRUE(
+      parser.InitTest("testing/resources/parser_rebuildxref_correct.pdf"));
+
+  ASSERT_TRUE(parser.RebuildCrossRef());
+  const FX_FILESIZE offsets[] = {0, 15, 61, 154, 296, 374, 450};
+  const FX_WORD versions[] = {0, 0, 2, 4, 6, 8, 0};
+  static_assert(FX_ArraySize(offsets) == FX_ArraySize(versions),
+                "numbers of offsets and versions should be same.");
+  ASSERT_EQ(FX_ArraySize(offsets), parser.m_CrossRef.GetSize());
+  ASSERT_EQ(FX_ArraySize(versions), parser.m_ObjVersion.GetSize());
+
+  for (int i = 0; i < FX_ArraySize(offsets); ++i) {
+    EXPECT_EQ(offsets[i], parser.m_CrossRef.GetAt(i));
+    EXPECT_EQ(versions[i], parser.m_ObjVersion.GetAt(i));
+  }
+}