Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Issue 1408983006: Remove obsolete 'arguments' local variable handling. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete 'arguments' local variable handling. This removes special casing for the 'f.arguments' property accessor. Any local 'arguments' variable should not be allowed to influence the value returned by the indirect 'f.arguments' property. That property creates a new object with a separate identity everytime it is read. This is by now consistent with other browsers. R=rossberg@chromium.org TEST=mjsunit/arguments-indirect Committed: https://crrev.com/124efdd3e857bca3f68c44a6beb8bea9222c2524 Cr-Commit-Position: refs/heads/master@{#31776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -14 lines 0 comments Download
M test/mjsunit/arguments-indirect.js View 2 chunks +9 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mozilla/mozilla.status View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-03 16:40:59 UTC) #1
Benedikt Meurer
LGTM!
5 years, 1 month ago (2015-11-04 09:12:29 UTC) #3
rossberg
Yes please!
5 years, 1 month ago (2015-11-04 10:23:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408983006/1
5 years, 1 month ago (2015-11-04 10:34:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 10:35:52 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 10:36:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/124efdd3e857bca3f68c44a6beb8bea9222c2524
Cr-Commit-Position: refs/heads/master@{#31776}

Powered by Google App Engine
This is Rietveld 408576698